Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hiddenArg not working on windows. #39

Merged
merged 1 commit into from
Sep 12, 2016
Merged

Conversation

razzeee
Copy link
Contributor

@razzeee razzeee commented Aug 28, 2016

This should fix the hidden args being ignored when calling squirrel/update.exe.
See: https://github.com/Squirrel/Squirrel.Windows/blob/ee32fb469fc1ace0af6aef7edc389e27b8c063bb/src/Update/Program.cs#L128

Probably closes #31

@adam-lynch
Copy link
Contributor

OK thanks but this module supports NW.js and Electron users who don't use Squirrel. We could either an option that basically says "I'm using Squirrel" or somehow detect it? Not sure how reliable that would be.

@razzeee
Copy link
Contributor Author

razzeee commented Aug 31, 2016

Okay thought that might be the case, but didn't think that those also have updateDotExe

Edit: No clue how we could detect it

@adam-lynch
Copy link
Contributor

but didn't think that those also have updateDotExe

Woops, yeah that makes sense. But doesn't that mean you should only change the args inside the if fs.existsSync(updateDotExe) and versions.electron and leave it as it was outside?

@razzeee
Copy link
Contributor Author

razzeee commented Sep 12, 2016

Damn, that makes so much sense and could solve all our problems. PR update incoming.
Thx @adam-lynch

@adam-lynch adam-lynch merged commit 50e0053 into Teamwork:master Sep 12, 2016
@adam-lynch
Copy link
Contributor

4.0.1 is now published with this fix. Thanks very much @razzeee 👍

@razzeee razzeee deleted the patch-1 branch September 12, 2016 20:03
@razzeee
Copy link
Contributor Author

razzeee commented Sep 12, 2016

Thank you for bringing me to the conclusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electron app not hidden on startup
2 participants