fix(tee): lowercase enum TEE types #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We encountered an issue where the staging environment was unable to deserialize `sgx` to `TeeType::Sgx`. Relevant code: - https://github.com/matter-labs/zksync-era/blob/87b02e3ab5c1f61d59dd0f0eefa9ec33a7b55488/core/lib/basic_types/src/tee_types.rs#L7 - https://github.com/matter-labs/teepot/blob/537521f0ee2bd704fb839fe336f43f8aab5887df/bin/tee-key-preexec/src/main.rs#L53 Relevant logs: - https://grafana.matterlabs.dev/goto/Q5ENugeSR?orgId=1
pbeza
force-pushed
the
tee/fix/lowercase-enum-tee-types
branch
from
f9e12bd to
9425d3a
Compare
pbeza
changed the title
popzxc
reviewed
Sep 4, 2024
popzxc
reviewed
Sep 4, 2024
|
Ugh, I really hate all these flaky tests I have to keep watching and restarting manually. Do you have any automation to reschedule them? :P Anyway, @popzxc, I think this PR is good to go. ✅ |
popzxc
reviewed
Sep 5, 2024
pbeza
force-pushed
the
tee/fix/lowercase-enum-tee-types
branch
from
955590e to
ae10700
Compare
popzxc
approved these changes
Sep 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
🤖 I have created a release *beep* *boop* --- ## [24.24.0](core-v24.23.0...core-v24.24.0) (2024-09-05) ### Features * conditional cbt l1 updates ([#2748](#2748)) ([6d18061](6d18061)) * **eth-watch:** do not query events from earliest block ([#2810](#2810)) ([1da3f7e](1da3f7e)) * **genesis:** Validate genesis config against L1 ([#2786](#2786)) ([b2dd9a5](b2dd9a5)) * Integrate tracers and implement circuits tracer in vm2 ([#2653](#2653)) ([87b02e3](87b02e3)) * Move prover data to /home/popzxc/workspace/current/zksync-era/prover/data ([#2778](#2778)) ([62e4d46](62e4d46)) * Remove prover db from house keeper ([#2795](#2795)) ([85b7346](85b7346)) * **vm-runner:** Implement batch data prefetching ([#2724](#2724)) ([d01840d](d01840d)) * **vm:** Extract batch executor to separate crate ([#2702](#2702)) ([b82dfa4](b82dfa4)) * **vm:** Simplify VM interface ([#2760](#2760)) ([c3bde47](c3bde47)) * **zk_toolbox:** add multi-chain CI integration test ([#2594](#2594)) ([05c940e](05c940e)) ### Bug Fixes * **config:** Do not panic for observability config ([#2639](#2639)) ([1e768d4](1e768d4)) * **core:** Batched event processing support for Reth ([#2623](#2623)) ([958dfdc](958dfdc)) * return correct witness inputs ([#2770](#2770)) ([2516e2e](2516e2e)) * **tee-prover:** increase retries to reduce spurious alerts ([#2776](#2776)) ([4fdc806](4fdc806)) * **tee-prover:** mitigate panic on redeployments ([#2764](#2764)) ([178b386](178b386)) * **tee:** lowercase enum TEE types ([#2798](#2798)) ([0f2f9bd](0f2f9bd)) * **vm-runner:** Fix statement timeouts in VM playground ([#2772](#2772)) ([d3cd553](d3cd553)) ### Performance Improvements * **vm:** Fix VM performance regression on CI loadtest ([#2782](#2782)) ([bc0d7d5](bc0d7d5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
We encountered an issue where the staging environment was unable to deserialize
sgxtoTeeType::Sgx. Relevant code:zksync-era/core/lib/basic_types/src/tee_types.rs
Line 7 in 87b02e3
Relevant logs:
Why ❔
To fix a panic in the staging environment.
Checklist
zk fmtandzk lint.