Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vm): Simplify VM interface #2760

Merged
merged 6 commits into from
Aug 29, 2024
Merged

feat(vm): Simplify VM interface #2760

merged 6 commits into from
Aug 29, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Aug 28, 2024 •
edited
Loading

What ❔

Simplifies low-level VM interface (i.e., VmInterface trait).

Why ❔

To make it easier to use / maintain.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@slowli
Copy link
Contributor Author

slowli commented Aug 28, 2024 •
edited
Loading

This is a simple / less controversial part of refactoring. It still leaves multiple ways to execute transactions on the VM (push_transaction + inspect or inspect_transaction), which doesn't look too good. Also, I'm not sure what Bootloader execution mode does; if it's removed, I think inspect could be removed altogether in favor of finish_batch and inspect_transaction.

Also, I'm not sure where VmInterface is used outside this repo (other than the test node). These changes look safe enough in any case though; for most removed methods, equivalent data can be retrieved using other means.

@slowli slowli marked this pull request as ready for review August 28, 2024 13:59
popzxc
popzxc previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions GitHub Actions
Copy link
Contributor

Detected VM performance changes

Benchmark name change in estimated runtime change in number of opcodes executed
call_far_legacy -2.2% N/A

Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it run out of gas at a different time. Or that it is behaving completely differently.

@slowli slowli requested a review from Deniallugo August 29, 2024 12:19
@slowli slowli added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@slowli slowli added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@slowli slowli added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@slowli slowli added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit c3bde47 Aug 29, 2024
48 checks passed
@slowli slowli deleted the aov-pla-1024-simplify-vminterface branch August 29, 2024 18:09
@zksync-era-bot zksync-era-bot mentioned this pull request Aug 29, 2024
Merged
@slowli slowli mentioned this pull request Sep 2, 2024
Merged
4 tasks
slowli added a commit that referenced this pull request Sep 3, 2024
@slowli
Revert "feat(vm): Simplify VM interface (#2760)"
5e8e2b7 
This reverts commit c3bde47.
slowli added a commit that referenced this pull request Sep 3, 2024
@slowli
Revert "feat(vm): Simplify VM interface (#2760)"
ba9cc7b 
This reverts commit c3bde47.
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
@slowli
perf(vm): Fix VM performance regression on CI loadtest (#2782)
bc0d7d5 
## What ❔

Fixes VM performance regression on CI loadtest introduced in
#2760.

## Why ❔

Changes in the VM interface made the VM eagerly clone compressed
bytecodes if compression hasn't failed. Compressed bytecodes aren't used
during sandboxed VM execution in the API server (the sandbox only checks
that compression is successful).For new VMs, bytecodes can be borrowed
from the VM state, which is what this PR does using `Cow`.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.
github-merge-queue bot pushed a commit that referenced this pull request Sep 5, 2024
@zksync-era-bot
chore(main): release core 24.24.0 (#2773)
fcffb06 
🤖 I have created a release *beep* *boop*
---


##
[24.24.0](core-v24.23.0...core-v24.24.0)
(2024-09-05)


### Features

* conditional cbt l1 updates
([#2748](#2748))
([6d18061](6d18061))
* **eth-watch:** do not query events from earliest block
([#2810](#2810))
([1da3f7e](1da3f7e))
* **genesis:** Validate genesis config against L1
([#2786](#2786))
([b2dd9a5](b2dd9a5))
* Integrate tracers and implement circuits tracer in vm2
([#2653](#2653))
([87b02e3](87b02e3))
* Move prover data to
/home/popzxc/workspace/current/zksync-era/prover/data
([#2778](#2778))
([62e4d46](62e4d46))
* Remove prover db from house keeper
([#2795](#2795))
([85b7346](85b7346))
* **vm-runner:** Implement batch data prefetching
([#2724](#2724))
([d01840d](d01840d))
* **vm:** Extract batch executor to separate crate
([#2702](#2702))
([b82dfa4](b82dfa4))
* **vm:** Simplify VM interface
([#2760](#2760))
([c3bde47](c3bde47))
* **zk_toolbox:** add multi-chain CI integration test
([#2594](#2594))
([05c940e](05c940e))


### Bug Fixes

* **config:** Do not panic for observability config
([#2639](#2639))
([1e768d4](1e768d4))
* **core:** Batched event processing support for Reth
([#2623](#2623))
([958dfdc](958dfdc))
* return correct witness inputs
([#2770](#2770))
([2516e2e](2516e2e))
* **tee-prover:** increase retries to reduce spurious alerts
([#2776](#2776))
([4fdc806](4fdc806))
* **tee-prover:** mitigate panic on redeployments
([#2764](#2764))
([178b386](178b386))
* **tee:** lowercase enum TEE types
([#2798](#2798))
([0f2f9bd](0f2f9bd))
* **vm-runner:** Fix statement timeouts in VM playground
([#2772](#2772))
([d3cd553](d3cd553))


### Performance Improvements

* **vm:** Fix VM performance regression on CI loadtest
([#2782](#2782))
([bc0d7d5](bc0d7d5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonazan joonazan joonazan left review comments

@popzxc popzxc popzxc approved these changes

@Deniallugo Deniallugo Deniallugo approved these changes

@perekopskiy perekopskiy Awaiting requested review from perekopskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slowli @Deniallugo @popzxc @joonazan