-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prover): Make it possible to run prover out of GCP #2448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in private messages, this needs a "switch" somewhere in code to ensure our costs don't go up drastically.
a321ffa
to
a6b909d
Compare
a6b909d
to
b756014
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already looks much better. Thanks a million for going through the effort.
Nit: It would be great to add a small entry on running provers locally about which var to change to what such that proving locally can work. Can also be tackled as a follow-up PR.
🤖 I have created a release *beep* *boop* --- ## [24.10.0](core-v24.9.0...core-v24.10.0) (2024-07-22) ### Features * Add blob size metrics ([#2411](#2411)) ([41c535a](41c535a)) * **en:** Switch EN to use node framework ([#2427](#2427)) ([0cee530](0cee530)) * **eth-sender:** add early return in sending new transactions to not spam logs with errors ([#2425](#2425)) ([192f2a3](192f2a3)) * **eth-watch:** Integrate decentralized upgrades ([#2401](#2401)) ([5a48e10](5a48e10)) * L1 batch signing (BFT-474) ([#2414](#2414)) ([ab699db](ab699db)) * **prover:** Make it possible to run prover out of GCP ([#2448](#2448)) ([c9da549](c9da549)) * **zk_toolbox:** Small adjustment for zk toolbox ([#2424](#2424)) ([ce43c42](ce43c42)) ### Bug Fixes * **eth-sender:** add bump of min 10% when resending txs to avoid "replacement transaction underpriced" ([#2422](#2422)) ([a7bcf5d](a7bcf5d)) * Set attesters in Connection::adjust_genesis (BFT-489) ([#2429](#2429)) ([ca4cb3c](ca4cb3c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
🤖 I have created a release *beep* *boop* --- ## [16.1.0](prover-v16.0.0...prover-v16.1.0) (2024-07-24) ### Features * **prover:** Make it possible to run prover out of GCP ([#2448](#2448)) ([c9da549](c9da549)) * remove leftovers after BWIP ([#2456](#2456)) ([990676c](990676c)) ### Bug Fixes * **prover:** BWG optimizations ([#2469](#2469)) ([d8851c8](d8851c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
What ❔
When zone read domain name cannot be resolved, assumes local environment and useslocal
zone.RegionFetcher
structure that can fetch the zone based on configuration.Why ❔
Makes it possible to run prover locally.
Checklist
zk fmt
andzk lint
.