Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prover): Make it possible to run prover out of GCP #2448

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Jul 22, 2024

What ❔

When zone read domain name cannot be resolved, assumes local environment and uses local zone.

  • Introduces a new config to choose cloud type, either GCP or local.
  • Creates RegionFetcher structure that can fetch the zone based on configuration.
  • Introduces strong typing for zone.

Why ❔

Makes it possible to run prover locally.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@popzxc popzxc requested review from EmilLuta and AntonD3 July 22, 2024 04:21
Artemka374
Artemka374 previously approved these changes Jul 22, 2024
Copy link
Contributor

@Artemka374 Artemka374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in private messages, this needs a "switch" somewhere in code to ensure our costs don't go up drastically.

@popzxc popzxc removed the request for review from AntonD3 July 22, 2024 08:07
@popzxc popzxc force-pushed the popzxc-local-prover branch from a321ffa to a6b909d Compare July 22, 2024 08:07
@popzxc popzxc force-pushed the popzxc-local-prover branch from a6b909d to b756014 Compare July 22, 2024 08:09
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already looks much better. Thanks a million for going through the effort.

Nit: It would be great to add a small entry on running provers locally about which var to change to what such that proving locally can work. Can also be tackled as a follow-up PR.

core/lib/config/src/configs/fri_prover.rs Show resolved Hide resolved
prover/proof_fri_compressor/Cargo.toml Show resolved Hide resolved
@popzxc popzxc added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit c9da549 Jul 22, 2024
56 checks passed
@popzxc popzxc deleted the popzxc-local-prover branch July 22, 2024 09:03
github-merge-queue bot pushed a commit that referenced this pull request Jul 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[24.10.0](core-v24.9.0...core-v24.10.0)
(2024-07-22)


### Features

* Add blob size metrics
([#2411](#2411))
([41c535a](41c535a))
* **en:** Switch EN to use node framework
([#2427](#2427))
([0cee530](0cee530))
* **eth-sender:** add early return in sending new transactions to not
spam logs with errors
([#2425](#2425))
([192f2a3](192f2a3))
* **eth-watch:** Integrate decentralized upgrades
([#2401](#2401))
([5a48e10](5a48e10))
* L1 batch signing (BFT-474)
([#2414](#2414))
([ab699db](ab699db))
* **prover:** Make it possible to run prover out of GCP
([#2448](#2448))
([c9da549](c9da549))
* **zk_toolbox:** Small adjustment for zk toolbox
([#2424](#2424))
([ce43c42](ce43c42))


### Bug Fixes

* **eth-sender:** add bump of min 10% when resending txs to avoid
"replacement transaction underpriced"
([#2422](#2422))
([a7bcf5d](a7bcf5d))
* Set attesters in Connection::adjust_genesis (BFT-489)
([#2429](#2429))
([ca4cb3c](ca4cb3c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jul 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[16.1.0](prover-v16.0.0...prover-v16.1.0)
(2024-07-24)


### Features

* **prover:** Make it possible to run prover out of GCP
([#2448](#2448))
([c9da549](c9da549))
* remove leftovers after BWIP
([#2456](#2456))
([990676c](990676c))


### Bug Fixes

* **prover:** BWG optimizations
([#2469](#2469))
([d8851c8](d8851c8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants