feat(en): Switch EN to use node framework #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
commented
Jul 11, 2024
slowli
reviewed
Jul 11, 2024
RomanBrodetski
approved these changes
Jul 12, 2024
|
I will fix nitpicks in a follow-up PR. |
Deniallugo
approved these changes
Jul 12, 2024
|
|
||
| /// Run the node using the node framework. | ||
| #[arg(long)] | ||
| use_node_framework: bool, |
There was a problem hiding this comment.
it's incompatible, have you checked, that we don't use it in gitops ?
There was a problem hiding this comment.
Of course. EN wasn't fully ported to the framework until this PR, it wouldn't have worked with it
irnb
pushed a commit
to vianetwork/via-server
that referenced
this pull request
Jul 12, 2024
## What ❔ This PR ports remaining parts of the EN to node framework and makes framework the default way to run it. In more detail: - Config for the health check limits are now set from config. - EN and rust metrics are now exposed; the protocol version update task now runs. -⚠️ Connection pool healthcheck was removed. It was controversial initially, its usefulness is not clear, it was supposed to be refactored a year ago but didn't, and it wasn't working well when testing. See [linear issue](https://linear.app/matterlabs/issue/PLA-255/revamp-db-connection-health-check) for more context. - Tests were reworked to use node framework; some refactoring was also applied to reduce boilerplate. - Additional tests were added to check for invalid EN configurations. -⚠️ Node framework was made the default way to run the EN. There is also a hook to force EN to run the old way, so that we don't have to rollback over small issues. ## Why ❔ - Part of switch to the node framework. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
🤖 I have created a release *beep* *boop* --- ## [24.10.0](core-v24.9.0...core-v24.10.0) (2024-07-22) ### Features * Add blob size metrics ([#2411](#2411)) ([41c535a](41c535a)) * **en:** Switch EN to use node framework ([#2427](#2427)) ([0cee530](0cee530)) * **eth-sender:** add early return in sending new transactions to not spam logs with errors ([#2425](#2425)) ([192f2a3](192f2a3)) * **eth-watch:** Integrate decentralized upgrades ([#2401](#2401)) ([5a48e10](5a48e10)) * L1 batch signing (BFT-474) ([#2414](#2414)) ([ab699db](ab699db)) * **prover:** Make it possible to run prover out of GCP ([#2448](#2448)) ([c9da549](c9da549)) * **zk_toolbox:** Small adjustment for zk toolbox ([#2424](#2424)) ([ce43c42](ce43c42)) ### Bug Fixes * **eth-sender:** add bump of min 10% when resending txs to avoid "replacement transaction underpriced" ([#2422](#2422)) ([a7bcf5d](a7bcf5d)) * Set attesters in Connection::adjust_genesis (BFT-489) ([#2429](#2429)) ([ca4cb3c](ca4cb3c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR ports remaining parts of the EN to node framework and makes framework the default way to run it.
In more detail:
Why ❔
Checklist
zk fmtandzk lint.