-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getter for full verification key #495
Closed
Closed
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,30 @@ struct VerifierParams { | |
bytes32 recursionCircuitsSetVksHash; | ||
} | ||
|
||
/// @notice A struct that represents an elliptic curve point. | ||
struct ECPoint { | ||
uint256 x; | ||
uint256 y; | ||
} | ||
|
||
/// @notice A struct that represents the verification key data. | ||
struct VerificationKeyData { | ||
/// @notice 8 points for gate setups | ||
ECPoint[8] gateSetup; | ||
/// @notice 2 points for gate selectors | ||
ECPoint[2] gateSelectors; | ||
/// @notice 4 points for permutations | ||
ECPoint[4] permutation; | ||
/// @notice A point element for lookup selector | ||
ECPoint lookupSelector; | ||
/// @notice 4 points for lookup tables | ||
ECPoint[4] lookupTable; | ||
/// @notice A point for lookup table type | ||
ECPoint lookupTableType; | ||
/// @notice A flag that denotes whether recursion is supported | ||
uint256 recursiveFlag; | ||
} | ||
|
||
/// @title The interface of the Verifier contract, responsible for the zero knowledge proof verification. | ||
/// @author Matter Labs | ||
/// @custom:security-contact [email protected] | ||
|
@@ -25,4 +49,9 @@ interface IVerifier { | |
/// @notice Calculates a keccak256 hash of the runtime loaded verification keys. | ||
/// @return vkHash The keccak256 hash of the loaded verification keys. | ||
function verificationKeyHash() external pure returns (bytes32); | ||
|
||
/// @notice Returns the verification key. | ||
/// @dev IMPORTANT: The outside developers should not expect this method to always return result in the same | ||
/// format. It might be changed in case of the change of the verification key format. | ||
function verificationKey() external pure returns (VerificationKeyData memory); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be all in plural?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure,
setup
I believe should be in singular. Permutations not sure cc @olesHolemThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are four distinct polynomials that define one permutation. I think
permutationPolys
andgateSetupPolys
could be a good namingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PS in the Plonk whitepaper they are also mentioned like
permutation polynomials