Getter for full verification key #495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladbochok
reviewed
May 27, 2024
Comment on lines
+22
to
+25
| /// @notice 2 points for gate selectors | ||
| ECPoint[2] gateSelectors; | ||
| /// @notice 4 points for permutations | ||
| ECPoint[4] permutation; |
There was a problem hiding this comment.
- setup
- selectors
- permutation
Should be all in plural?
There was a problem hiding this comment.
not sure, setup I believe should be in singular. Permutations not sure cc @olesHolem
There was a problem hiding this comment.
These are four distinct polynomials that define one permutation. I think permutationPolys and gateSetupPolys could be a good naming
There was a problem hiding this comment.
PS in the Plonk whitepaper they are also mentioned like permutation polynomials
|
The feature that required this change has been removed from the timeline, so I close this PR as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist