feat: EVM Interpreter in Yul #327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sstore instruction
This way it reflects the official docs
…king Add gas tracking and properly return values instead of relying on the sstore instruction
[EVM-Equivalent-YUL] Add `or` and `push` implementation
[EVM-Equivalent-YUL] Add exp and signextend opcodes
[EVM-Equivalent-YUL] Add addmod and mulmod opcodes
With this change, the function will stop doing N (from pushN) `add`s, but only one, whatever N be.
[EVM-Equivalent-YUL] Add div, sdiv, mod, smod opcodes
[EVM-Equivalent-YUL] Optimize readBytes function used by pushN opcodes
…xpansion [EVM-Equivalent-Yul] Add memory expansion functions
[EVM-Equivalent-Yul] Add mload, mstore and mstore8 opcodes
[EVM-Equivalent-YUL] Stack/Memory instructions sload, sstore and msize
[EVM-Equivalent-Yul] Add some environment opcodes
[EVM-Equivalent-Yul] Add more environment opcodes
…odes [EVM-Equivalent-YUL] Add block-environment opcodes
[EVM-Equivalent-Yul] Add gas charge to lacking opcodes
chen-robert
reviewed
Apr 13, 2024
|
|
||
| ip := add(ip, 1) | ||
|
|
||
| switch opcode |
There was a problem hiding this comment.
I believe YUL handling of switch statements is very inefficient. You may need to write this in BALLS instead.
| } | ||
|
|
||
| function pushStackItem(sp, item) -> newSp { | ||
| if or(gt(sp, BYTECODE_OFFSET()), eq(sp, BYTECODE_OFFSET())) { |
There was a problem hiding this comment.
Do you have an off-by-one here? I think you might be able to write to BYTECODE_OFFSET().
| opcode := and(mload(sub(ip, 31)), 0xff) | ||
| } | ||
|
|
||
| function readBytes(start, length) -> value { |
There was a problem hiding this comment.
length is a constant and this function will be specialized anyways -- maybe you should mask here instead of using a loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist