Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EVM-Equivalent-Yul] Add memory expansion functions #343

Merged
merged 1 commit into from
Apr 12, 2024
Merged

[EVM-Equivalent-Yul] Add memory expansion functions #343

merged 1 commit into from
Apr 12, 2024

Conversation

jrchatruc
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@ManuelBilbao ManuelBilbao mentioned this pull request Apr 10, 2024
Merged
3 tasks
gianbelinche
gianbelinche approved these changes Apr 12, 2024
View reviewed changes
Copy link

@gianbelinche gianbelinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ManuelBilbao
ManuelBilbao approved these changes Apr 12, 2024
View reviewed changes
Copy link

@ManuelBilbao ManuelBilbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Solidity implementation doesn't override memory with zeros neither, so we should go this way as it's cleaner

@jrchatruc jrchatruc merged commit 9e8c33e into evm-equivalence-yul Apr 12, 2024
17 of 18 checks passed
@jrchatruc jrchatruc deleted the evm-equivalence-yul-memory-expansion branch April 12, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianbelinche gianbelinche gianbelinche approved these changes

@ManuelBilbao ManuelBilbao ManuelBilbao approved these changes

@vladbochok vladbochok Awaiting requested review from vladbochok

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrchatruc @ManuelBilbao @gianbelinche