Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing swagger type annotations for BFF endpoints #314

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: add missing swagger type annotations for BFF endpoints #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/app-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ name: BE App E2E tests

on:
workflow_call:
secrets:
ALLURE_TOKEN:
description: 'A token passed from the caller workflow'
required: true
# secrets:
# ALLURE_TOKEN:
# description: 'A token passed from the caller workflow'
# required: true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allure reports were disabled for the time being, so this variable is not used. However, since it's required, the workflow fails for forked PRs.

inputs:
environmentTags:
type: string
Expand Down
3 changes: 3 additions & 0 deletions packages/api/src/address/address.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export class AddressController {
@Get(":address")
@ApiParam({
name: "address",
type: String,
schema: { pattern: ADDRESS_REGEX_PATTERN },
example: constants.address,
description: "Valid hex address",
Expand Down Expand Up @@ -106,6 +107,7 @@ export class AddressController {
@Get(":address/logs")
@ApiParam({
name: "address",
type: String,
schema: { pattern: ADDRESS_REGEX_PATTERN },
example: constants.contractAddressWithLogs,
description: "Valid hex address",
Expand All @@ -130,6 +132,7 @@ export class AddressController {
@Get(":address/transfers")
@ApiParam({
name: "address",
type: String,
schema: { pattern: ADDRESS_REGEX_PATTERN },
example: constants.address,
description: "Valid hex address",
Expand Down
2 changes: 2 additions & 0 deletions packages/api/src/token/token.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export class TokenController {
@Get(":address")
@ApiParam({
name: "address",
type: String,
schema: { pattern: ADDRESS_REGEX_PATTERN },
example: constants.tokenAddress,
description: "Valid hex address",
Expand All @@ -75,6 +76,7 @@ export class TokenController {
@Get(":address/transfers")
@ApiParam({
name: "address",
type: String,
schema: { pattern: ADDRESS_REGEX_PATTERN },
example: constants.tokenAddress,
description: "Valid hex address",
Expand Down
3 changes: 3 additions & 0 deletions packages/api/src/transaction/transaction.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export class TransactionController {
@Get(":transactionHash")
@ApiParam({
name: "transactionHash",
type: String,
schema: { pattern: TX_HASH_REGEX_PATTERN },
example: constants.txHash,
description: "Valid transaction hash",
Expand All @@ -84,6 +85,7 @@ export class TransactionController {
@Get(":transactionHash/transfers")
@ApiParam({
name: "transactionHash",
type: String,
schema: { pattern: TX_HASH_REGEX_PATTERN },
example: constants.txHash,
description: "Valid transaction hash",
Expand Down Expand Up @@ -114,6 +116,7 @@ export class TransactionController {
@Get(":transactionHash/logs")
@ApiParam({
name: "transactionHash",
type: String,
schema: { pattern: TX_HASH_REGEX_PATTERN },
example: constants.txHash,
description: "Valid transaction hash",
Expand Down
Loading