fix: add missing swagger type annotations for BFF endpoints #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasyl-ivanchuk
commented
Nov 11, 2024
| # secrets: | ||
| # ALLURE_TOKEN: | ||
| # description: 'A token passed from the caller workflow' | ||
| # required: true |
There was a problem hiding this comment.
Allure reports were disabled for the time being, so this variable is not used. However, since it's required, the workflow fails for forked PRs.
API E2E Test Results207 tests 207 ✅ 19s ⏱️ Results for commit 5194286. |
Unit Test Results 4 files 263 suites 11m 2s ⏱️ Results for commit 5194286. |
|
Visit the preview URL for this PR: |
JackHamer09
approved these changes
Nov 11, 2024
|
🎉 This PR is included in version 2.50.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Add missing swagger type annotations for BFF endpoints.
Why ❔
Auto code generators that work based on the Swagger docs rely on the specified Swagger type, and if it's missing, they assume the parameter is of the object type.
Checklist