Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permissions for community.aws PR 565 #148

Merged
merged 5 commits into from
May 6, 2021
Merged

Update permissions for community.aws PR 565 #148

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
54511ff
update permissions for community.aws PR 565
badnetmask May 5, 2021
dd664ea
remove unnecessary permission as requested
badnetmask May 5, 2021
1c4f850
removing another duplicate policy
badnetmask May 6, 2021
1a2b11b
Merge remote-tracking branch 'upstream/master' into awspr565
badnetmask May 6, 2021
8326aa2
Merge branch 'master' into awspr565
jillr May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions aws/policy/networking.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ Statement:
- route53:GetHostedZone
- route53:DeleteHostedZone
- route53:UpdateHostedZoneComment
- route53:ChangeTagsForResource
- route53:ListTagsForResource
Resource: "*"
- Sid: AllowRegionalUnrestrictedResourceActionsWhichIncurNoFees
Effect: Allow
Expand Down Expand Up @@ -38,6 +40,7 @@ Statement:
- ec2:CreateRouteTable
- ec2:CreateSecurityGroup
- ec2:CreateSubnet
- ec2:CreateTags
badnetmask marked this conversation as resolved.
Show resolved Hide resolved
- ec2:CreateVpc
- ec2:CreateVpcEndpoint
- ec2:CreateVpcPeeringConnection
Expand Down Expand Up @@ -71,6 +74,7 @@ Statement:
- ec2:DescribeRouteTables
- ec2:DescribeSecurityGroups
- ec2:DescribeSubnets
- ec2:DescribeTags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ec2:DescribeTags

The EC2 Tags permissions are over in the compute policy and should already be there.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ec2:DescribeTags here duplicates the ec2:DescribeTags in compute.yaml. Amazon limits policy size (by character count) and we tend to run into those limits so it's helpful to avoid duplication.

- ec2:DescribeVpcAttribute
- ec2:DescribeVpcClassicLink
- ec2:DescribeVpcClassicLinkDnsSupport
Expand Down