Update permissions for community.aws PR 565 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
suggested changes
May 5, 2021
aws/policy/networking.yaml
Outdated
| @@ -71,6 +74,7 @@ Statement: | |||
| - ec2:DescribeRouteTables | |||
| - ec2:DescribeSecurityGroups | |||
| - ec2:DescribeSubnets | |||
| - ec2:DescribeTags | |||
There was a problem hiding this comment.
Suggested change
| - ec2:DescribeTags |
The EC2 Tags permissions are over in the compute policy and should already be there.
There was a problem hiding this comment.
ec2:DescribeTags here duplicates the ec2:DescribeTags in compute.yaml. Amazon limits policy size (by character count) and we tend to run into those limits so it's helpful to avoid duplication.
jillr
requested changes
May 6, 2021
aws/policy/networking.yaml
Outdated
| @@ -71,6 +74,7 @@ Statement: | |||
| - ec2:DescribeRouteTables | |||
| - ec2:DescribeSecurityGroups | |||
| - ec2:DescribeSubnets | |||
| - ec2:DescribeTags | |||
There was a problem hiding this comment.
ec2:DescribeTags here duplicates the ec2:DescribeTags in compute.yaml. Amazon limits policy size (by character count) and we tend to run into those limits so it's helpful to avoid duplication.
Pushed an update. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended by @tremble, this PR updates permissions that allows integration tests to run for community.aws PR 565.