Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong image URL #16

Open
Karmalakas opened this issue Feb 10, 2021 · 0 comments
Open

Wrong image URL #16

Karmalakas opened this issue Feb 10, 2021 · 0 comments

Comments

@Karmalakas
Copy link
Contributor

Karmalakas commented Feb 10, 2021 •
edited
Loading

I've uploaded logo.jpg to my home page. File appeared in /user/pages/01.home/logo.jpg right next to .md files, but Aura generates wrong URLs for all 3 places (og:image, twitter:image and in a JSON). It shows URL as mypaga.tld/logo.jpg, which gets routed to not found /error page. URLs should be /user/pages/01.home/logo.jpg AFAIK, shouldn't they?

And for second language (/en in my case) it makes mypage.tld/en/logo.jpg URL, which doesn't make sense actually

Grav v1.7.5
Admin v1.10.3
Aura v2.1.1
Karmalakas added a commit to Karmalakas/grav-plugin-aura that referenced this issue Mar 6, 2021
@Karmalakas
Fix image URL and double encoded HTML entities
c3fc2ff 
Fix page image URL [Issue matt-j-m#16](matt-j-m#16)
Fix double encoded HTML entities [Issue matt-j-m#12](matt-j-m#12)
Fix code style (was very inconsistent)
Split object setting to separate methods
Add .gitignore IDE rules
@Karmalakas Karmalakas mentioned this issue Mar 6, 2021
Merged
matt-j-m added a commit that referenced this issue May 14, 2021
@matt-j-m
Bug fixes for Issue #12 and Issue #16 credit to @Karmalakas
2351eeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Karmalakas