Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latin extended character encoded #12

Closed
01Kuzma opened this issue Dec 18, 2020 · 7 comments
Closed

Latin extended character encoded #12

01Kuzma opened this issue Dec 18, 2020 · 7 comments

Comments

@01Kuzma
Copy link

01Kuzma commented Dec 18, 2020

Hi,
Found a bug:
The description uses Latin extended characters: "Senų baldų išvežimo ..."
The character "Š" is encoded into html entity " & scaron;"

@Karmalakas
Copy link
Contributor

Karmalakas commented Feb 10, 2021

Looking at source, š is encoded as š on my page :/
Also ' is encoded as '

Grav v1.7.5
Admin v1.10.3
Aura v2.1.1

Karmalakas added a commit to Karmalakas/grav-plugin-aura that referenced this issue Mar 6, 2021
Fix page image URL [Issue matt-j-m#16](matt-j-m#16)
Fix double encoded HTML entities [Issue matt-j-m#12](matt-j-m#12)
Fix code style (was very inconsistent)
Split object setting to separate methods
Add .gitignore IDE rules
@Karmalakas
Copy link
Contributor

@01Kuzma, check my PR and copy two aura.php files to your plugin. You'll have to re-save pages you need though. Hopefully this will get merged and will be able to update plugin as usual.

@01Kuzma
Copy link
Author

01Kuzma commented Mar 6, 2021

@Karmalakas thank you for PR, I will patch my files and try

@Karmalakas
Copy link
Contributor

Note, that this also changes how og:image URL is retrieved. Check this too ;)

@01Kuzma
Copy link
Author

01Kuzma commented Mar 6, 2021

I've checked it (have overwritten aura.php and classes/aura.php)

In og:image now the root of web project is added twice, for example:
https://localhost/transportopaslaugos/transportopaslaugos/user/pages/01.home/pervezimas.jpg

By the way, it's really strange, but before pulling the changes I haven't observed an old error with š encoding. Maybe it also was related to Grav Core? Now it's updated to 1.7.7 and description is displayed without issues...

@Karmalakas
Copy link
Contributor

By the way, it's really strange, but before pulling the changes I haven't observed an old error with š encoding. Maybe it also was related to Grav Core? Now it's updated to 1.7.7 and description is displayed without issues...

Do you mean without my fix it's OK now? Because I'm on 1.7.7 and it's double encoded without the fix. I don't see a reason why Aura would do htmlentites() at all, when Grav 1.7 escapes already what's needed and plugin works only with 1.7

@01Kuzma
Copy link
Author

01Kuzma commented Mar 6, 2021

Yes, without fix it was OK (I've just observed it today), now I've applied the fix too on localhost firslty. That's very strange, since that time, when I've described this issue I was just updating Grav and wasn't looking at a description characters... So, I can't tell when the changes happened on my projects.
But as you still encounter the same problem - your's fix is mandatory for Aura :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants