This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Paginated Sync #893
Closed
Paginated Sync #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto erikj/paginate_sync
erikjohnston
force-pushed
the
erikj/paginate_sync
branch
from
c18a26d
to
e5ae032
Compare
erikjohnston
force-pushed
the
erikj/paginate_sync
branch
from
e5ae032
to
f07f993
Compare
erikjohnston
force-pushed
the
erikj/paginate_sync
branch
from
2fc26dd
to
6c137b3
Compare
|
|
||
| missing_list = frozenset( | ||
| room_id for room_id, ts in | ||
| sorted(start_ts.items(), key=lambda item: -item[1]) |
|
What's the status on this? Is there a summary of the issues / intended or even a log of the discussion around somewhere? Probably related: element-hq/element-web#2825 element-hq/element-web#2737 |
pik
reviewed
Jan 5, 2017
| @@ -690,6 +791,12 @@ def _generate_sync_entry_for_rooms(self, sync_result_builder, account_data_by_ro | |||
|
|
|||
| tags_by_room = yield self.store.get_tags_for_user(user_id) | |||
|
|
|||
| yield self._update_room_entries_for_paginated_sync( | |||
There was a problem hiding this comment.
I might be missing something - but I don't think this is sufficient or an effective way to breakdown sync - since which room is synced is still not granular. The client should really be able to specify which room should be synced first, otherwise it's going to waste time syncing rooms which the user might not be currently interested in, no?
|
This is not going to happen because there is no one on the client side available to test it out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.