Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of deprecated /events api #459

Open
APwhitehat opened this issue Jul 1, 2018 · 3 comments
Open

Use of deprecated /events api #459

APwhitehat opened this issue Jul 1, 2018 · 3 comments

Comments

@APwhitehat
Copy link

tests/50federation/31room-send.pl relies on /events api which is deprecated.
sytest should use /sync.
https://matrix.org/docs/spec/client_server/r0.3.0.html#get-matrix-client-r0-events

@ara4n
Copy link
Member

ara4n commented Jul 1, 2018

/events is still used when peeking rooms, but the hope is to replace it entirely with /sync in the near future - probably when paginated /sync finally lands, as that gave a way to request /sync on arbitrary rooms (permission allowing).

@APwhitehat
Copy link
Author

My concern lies on the fact that sytest uses /events which makes dendrite fail many tests.
Which is not ideal because failure of the deprecated API means you cannot test other APIs.

@ara4n
Copy link
Member

ara4n commented Jul 1, 2018

yup, understood. i think the answer would be to mark those tests as non-critical for now, given /events is on the way out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants