Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Faster joins: use stable identifiers #14828

Closed
DMRobertson opened this issue Jan 12, 2023 · 1 comment · Fixed by #14832
Closed

Faster joins: use stable identifiers #14828

DMRobertson opened this issue Jan 12, 2023 · 1 comment · Fixed by #14832
Assignees
@DMRobertson
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@DMRobertson
Copy link
Contributor

DMRobertson commented Jan 12, 2023 •
edited
Loading

See:

Synapse issue: #14828
Synapse PR: #14832
Complement PR: matrix-org/complement#583
GMSL PR: matrix-org/gomatrixserverlib#350
MSC: matrix-org/matrix-spec-proposals#3706
Spec diff: matrix-org/matrix-spec#1393

Also related in Synapse: #14854, #14841
@DMRobertson DMRobertson added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jan 12, 2023
@DMRobertson
Copy link
Contributor Author

DMRobertson commented Jan 12, 2023 •
edited
Loading

Our thinking is to just do these renames and screw backwards compat. Experimental feature etc, no promises; if you want to use faster joins both you and the resident server will have to upgrade to some minimum Synapse version with the renames.

On second thought: to assist in testing/rollout we think that it will be prudent

  • to send both the old and new query parameter
  • to read the new response field, falling back to the old one

But we should consider it a future maintenance task to remove the fallback, say ~6 months' time.

@DMRobertson DMRobertson mentioned this issue Jan 12, 2023
Closed
@DMRobertson DMRobertson self-assigned this Jan 12, 2023
This was referenced Jan 12, 2023
Merged
Merged
@DMRobertson DMRobertson changed the title Faster joins: handle query parameter and field renames in MSC3706 Faster joins: use stable identifiers Jan 12, 2023
@DMRobertson DMRobertson mentioned this issue Jan 12, 2023
Merged
DMRobertson added a commit to matrix-org/gomatrixserverlib that referenced this issue Jan 13, 2023
@DMRobertson
Use stable identifiers from MSC3706 (Faster joins) (#350)
67e0601 
I haven't made any effort to maintain backwards compatibility (unlike in
matrix-org/synapse#14832). I'm happy to do so if
needed, but might need some guidance.

Synapse issue: matrix-org/synapse#14828
Synapse PR: matrix-org/synapse#14832
Complement PR: matrix-org/complement#583
GMSL PR: #350
MSC: matrix-org/matrix-spec-proposals#3706
Spec diff: matrix-org/matrix-spec#1393

### Pull Request Checklist

* [x] Pull request includes a [sign
off](https://github.com/matrix-org/dendrite/blob/master/docs/CONTRIBUTING.md#sign-off)

Signed-off-by: `David Robertson <[email protected]>`
@DMRobertson DMRobertson mentioned this issue Jan 16, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DMRobertson DMRobertson

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use stable identifiers for faster joins matrix-org/synapse
1 participant
@DMRobertson