-
-
Notifications
You must be signed in to change notification settings - Fork 831
sliding sync: Add test to verify we send unsubscribe_rooms
for every room switch
#9784
sliding sync: Add test to verify we send unsubscribe_rooms
for every room switch
#9784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know you could do this in Cypress! Might need a check from @t3chguy with his Cypress-fu, but this LGTM.
Looks sane to me, but in future if you name your branches the same then the CI will run them against each other, presumably the fail right now is due to the js-sdk changeset not being considered. Also might be worth probably checking the content of the |
… s7evink/slidingsyncroomswitch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the new test is failing
oh I see, that's expected. Still, we can't merge this until it is unblocked by matrix-org/matrix-js-sdk#2991. |
Thanks for approving this one, now lets wait for CI. :) |
This adds a test to verify that we send
unsubscribe_rooms
for every room switch.CI is going to fail for this test, as of now, as it needs matrix-org/matrix-js-sdk#2991
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.