Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sliding sync: Fix issue where no unsubs are sent when switching rooms #2991

Merged
merged 3 commits into from
Dec 20, 2022
Merged

sliding sync: Fix issue where no unsubs are sent when switching rooms #2991

merged 3 commits into from
Dec 20, 2022

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Dec 16, 2022 •
edited by github-actions bot
Loading

Should fix an issue where no unsubscribe_rooms are sent when switching rooms.
This happens because we're deleting the room from the confirmedRoomSubscription list when switching between unencrypted rooms and the unsubscribe_rooms list can't be calculated correctly, resulting in an ever growing subscriptions list on the server side.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • sliding sync: Fix issue where no unsubs are sent when switching rooms (#2991). Contributed by @S7evinK.

@S7evinK S7evinK requested a review from a team as a code owner December 16, 2022 10:54
@S7evinK S7evinK mentioned this pull request Dec 16, 2022
Merged
3 tasks
kegsay
kegsay approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need some Jest tests for this though.

t3chguy
t3chguy reviewed Dec 19, 2022
View reviewed changes
src/sliding-sync.ts Outdated Show resolved Hide resolved
@S7evinK @t3chguy
Update src/sliding-sync.ts
3872c5f 
Co-authored-by: Michael Telatynski <[email protected]>
@richvdh richvdh requested review from t3chguy and removed request for duxovni December 19, 2022 18:00
@kegsay kegsay merged commit 61e2606 into matrix-org:develop Dec 20, 2022
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Jan 19, 2023
@su-ex
Merge tag 'v23.1.0' into sc
e6c127a 
* Remove extensible events v1 field population on legacy events ([\matrix-org#3040](matrix-org#3040)).
* Improve hasUserReadEvent and getUserReadUpTo realibility with threads ([\matrix-org#3031](matrix-org#3031)). Fixes element-hq/element-web#24164.
* Remove video track when muting video ([\matrix-org#3028](matrix-org#3028)). Fixes element-hq/element-call#209.
* Make poll start event type available (PSG-962) ([\matrix-org#3034](matrix-org#3034)).
* Add alt event type matching in Relations model ([\matrix-org#3018](matrix-org#3018)).
* Remove usage of v1 Identity Server API ([\matrix-org#3003](matrix-org#3003)).
* Add `device_id` to `/account/whoami` types ([\matrix-org#3005](matrix-org#3005)).
* Implement MSC3912: Relation-based redactions ([\matrix-org#2954](matrix-org#2954)).
* Introduce a mechanism for using the rust-crypto-sdk ([\matrix-org#2969](matrix-org#2969)).
* Support MSC3391: Account data deletion ([\matrix-org#2967](matrix-org#2967)).
* Fix threaded cache receipt when event holds multiple receipts ([\matrix-org#3026](matrix-org#3026)).
* Fix false key requests after verifying new device ([\matrix-org#3029](matrix-org#3029)). Fixes element-hq/element-web#24167 and element-hq/element-web#23333.
* Avoid triggering decryption errors when decrypting redacted events ([\matrix-org#3004](matrix-org#3004)). Fixes element-hq/element-web#24084.
* bugfix: upload OTKs in sliding sync mode ([\matrix-org#3008](matrix-org#3008)).
* Apply edits discovered from sync after thread is initialised ([\matrix-org#3002](matrix-org#3002)). Fixes element-hq/element-web#23921.
* Sliding sync: Fix issue where no unsubs are sent when switching rooms ([\matrix-org#2991](matrix-org#2991)).
* Threads are missing from the timeline ([\matrix-org#2996](matrix-org#2996)). Fixes element-hq/element-web#24036.
* Close all streams when a call ends ([\matrix-org#2992](matrix-org#2992)). Fixes element-hq/element-call#742.
* Resume to-device message queue after resumed sync ([\matrix-org#2920](matrix-org#2920)). Fixes matrix-org/element-web-rageshakes#17170.
* Fix browser entrypoint ([\matrix-org#3051](matrix-org#3051)). Fixes matrix-org#3013.
* Fix failure to start in firefox private browser ([\matrix-org#3058](matrix-org#3058)). Fixes element-hq/element-web#24216.
* Correctly handle limited sync responses by resetting the thread timeline ([\matrix-org#3056](matrix-org#3056)). Fixes element-hq/element-web#23952.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kegsay kegsay kegsay approved these changes

@richvdh richvdh richvdh approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@t3chguy t3chguy Awaiting requested review from t3chguy

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@S7evinK @richvdh @t3chguy @kegsay