This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
prevent unread event for room with empty timeline #9144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
fixes element-hq/element-web#19560 Signed-off-by: smoebody <[email protected]>
t3chguy
reviewed
Aug 8, 2022
Comment on lines
+58
to
+61
| // if there is no timeline at all, e.g. by message retention | ||
| if (room.timeline.length === 0) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
This is insufficient, just because the client's loaded timeline has length 0, doesn't mean it has yet tried to backpaginate to see if there are any events. The server sends an unread count for a reason
turt2live
suggested changes
Aug 8, 2022
There was a problem hiding this comment.
It's not immediately clear to me that this is a solution to the issue at hand given the issue needs to be investigated and reviewed itself. In fact, the issue looks to be something we likely don't support or intend on supporting at this time, so a fix would be relatively inappropriate.
This PR might be best positioned to solve related issues though, so leaving it open for your consideration.
Thank you for taking the time to write a PR in any case!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes element-hq/element-web#19560
Checklist
No test perfomed on
doesRoomHaveUnreadMessagesLinter failed before my code already
This PR currently has none of the required changelog labels.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.