Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing the cache creates spurious unread markers for empty rooms #19560

Open
Biep opened this issue Oct 31, 2021 · 13 comments
Open

Clearing the cache creates spurious unread markers for empty rooms #19560

Biep opened this issue Oct 31, 2021 · 13 comments
Labels
A-Read-Marker Green line showing how far _you_ have read A-Read-Receipts O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Investigation

Comments

@Biep
Copy link

Biep commented Oct 31, 2021

My home server recently did a clean-up, with the result that some long unused rooms have zero events left. When I cleared my cache, all those rooms show up with an 'unread messages' marker - that I cannot get rid of. They also percolate to the top of the room list, pushing rooms with real unread messages down, and out of the letterbox.

@Biep
Copy link
Author

Biep commented Nov 1, 2021

The only way to get rid of the "unread messages" marker seems to be to post a message. Which is not always desirable, e.g. in emergency message rooms.

@germain-gg germain-gg added T-Defect A-Read-Marker Green line showing how far _you_ have read A-Read-Receipts O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist X-Needs-Investigation labels Nov 1, 2021
@germain-gg
Copy link
Contributor

Could you maybe elaborate a bit more regarding that clean-up.
How was it performed? By whom?

@Biep
Copy link
Author

Biep commented Nov 1, 2021

The server admins did that - see this message and this message. Any technical questions are better asked to the poster of those messages, who is one of the two admins.
I hope that helps..

@Biep
Copy link
Author

Biep commented Nov 1, 2021

Red marks still percolate to the top:
What it looks like

But others stay below the spurious ones:
Downtrodden

@bziemons
Copy link

bziemons commented May 4, 2022

Could you maybe elaborate a bit more regarding that clean-up. How was it performed? By whom?

Maybe I can answer this question, since I have the same Problem in Element Desktop (right now, Element version: 1.10.11, Olm version: 3.2.8) and I am my own server admin: I know the messages were deleted by Synapse through its retention policy.

@smoebody
Copy link

Is there a way to workaround this Problem? It is highly annoying and makes element unusable.

@bziemons
Copy link

Is there a way to workaround this Problem? It is highly annoying and makes element unusable.

I've been moving these conversations to low priority.. Works, but definitely not ideal.

smoebody pushed a commit to smoebody/matrix-react-sdk that referenced this issue Aug 8, 2022
smoebody pushed a commit to smoebody/matrix-react-sdk that referenced this issue Aug 8, 2022
smoebody added a commit to smoebody/matrix-react-sdk that referenced this issue Aug 8, 2022
@shoetten
Copy link

This also happens if the server has a message retention policy configured. If you clear the cache (or have to logout and login again for some reason) after the messages have been deleted on the server, you run into exactly this issue.
I know that message retention is still considered experimental, but many privacy focused homservers have it turned on already, resulting in this very annoying bug.

Feel free to ping me, if you need any more info than that, but it's fairly easy to reproduce.

@t3chguy
Copy link
Member

t3chguy commented Sep 12, 2022

@shoetten that's part of element-hq/element-meta#729 - given the client has no support for it, it won't be able to handle it's edge cases.

@smoebody
Copy link

I can report, that the markers have gone after upgrading to element 1.11.5 and synapse 1.67.0

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Sep 15, 2022

I can report, that the markers have gone after upgrading to element 1.11.5 and synapse 1.67.0

Hmm, that sounds interesting - Synapse 1.67.0 removes support for unstable private read receipts, maybe that is related.

Can anyone still see this?

@SimonBrandner SimonBrandner added the X-Needs-Info This issue is blocked awaiting information from the reporter label Sep 15, 2022
@bziemons
Copy link

just tested with Synapse 1.67.0 and Element version 1.11.5 - Sadly, I still see the issue.

@SimonBrandner SimonBrandner removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Sep 17, 2022
@smoebody
Copy link

i also disabled the retention-feature. maybe thats why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Read-Marker Green line showing how far _you_ have read A-Read-Receipts O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants