This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Order users in autocomplete by length #6348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
dbkr
added
the
T-Defect
turt2live
approved these changes
Jul 22, 2021
Signed-off-by: Šimon Brandner <[email protected]> Co-authored-by: Travis Ralston <[email protected]>
|
This seems like more of a product decision vs a design thing. Switched the reviewers ⏩ |
|
@SimonBrandner I know this has been a while but I think this is a risky change so we should close/not merge this. I can see the attraction of exact matching if searching for something short, but we'll break peoples existing muscle memory so it's a really high risk change. I also agree with Travis's comment that we should figure out some smarter relevancy metrics instead, perhaps informed by space membership too. Sorry to be the bearer of bad news! |
|
No worries, makes sense, could you please comment/close the issue? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#15609
This isn't an ideal solution since it doesn't take the server part of
mxids into account when searching for the reasons explained in element-hq/element-web#15609 (comment)