Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username completion ordering: shorter/exact match sorted after longer incomplete match #15609

Open
mcint opened this issue Oct 29, 2020 · 1 comment
Assignees
Labels
A-Autocomplete P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@mcint
Copy link

mcint commented Oct 29, 2020

Description

Username completion ordering: when I type a username, @... I expect to see the shorter/exact match sorted before the longer incomplete match, but this is not the current behavior.

Steps to reproduce

  • Find/create users with matching-prefix names, ideally where one username is a prefix of the other, @prefix & @prefixuser
  • Type @ to begin tagging, at @prefix
  • (I observe) @prefixuser first in the suggestions and tab completion, despite that it should come later in lexicographic order.

Is there some kind of special casing of completion on shorter or complete/terminated words/tokens?

Logs being sent: no

Screenshot

Shows chat text-entry box, with user-completion initiated.
Text: @dk
Completion: @dkess then @dk

Screen Shot 2020-10-29 at 9 42 46 AM-redact-2

Version information

  • Platform: desktop

For the desktop app:

  • OS: macOS
  • URL: private, 1.7.10
@jryans jryans added P2 S-Minor Impairs non-critical functionality or suitable workarounds exist A-Autocomplete labels Nov 19, 2020
@jryans jryans removed the Z-UI/UX label Mar 8, 2021
@SimonBrandner
Copy link
Contributor

I'll dump my thoughts here before I forget:

Originally, I thought this is going to be an easy thing to do but it doesn't seem to be that easy: We use both mxids and display names when searching. That means that if we try to order the completions by length and I type @mat, I'll get the user with mxid lx:matrix.org first (in #element-dev). The only solution I can see right now is to cut off the server part of the mxids, which isn't ideal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Autocomplete P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants