Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Make the text filter search all spaces instead of just the selected one #5942

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 28, 2021

Fixes element-hq/element-web#16998

@niquewoodhouse do you have any quick wins in terms of better explaining to the user that the text filter field will search across all your spaces rather than the selected one?

@t3chguy t3chguy marked this pull request as ready for review April 29, 2021 08:04
@t3chguy t3chguy requested review from a team April 29, 2021 08:04
@niquewoodhouse
Copy link
Contributor

@t3chguy what constraints do we have?

  • Would it be feasible to amend the room tile in someway (eg say which space the result will take them to)?
  • Would it be feasible to put them in a new section (eg 'rooms in other spaces)?
  • Would it be feasible to amend the filter hint to say 'filter all spaces'?
  • Would it be feasible to amend the results to say '13 results in all spaces' instead of '13 results'?

@t3chguy
Copy link
Member Author

t3chguy commented Apr 29, 2021

Would it be feasible to amend the room tile in someway

Possibly, depending on the exact design you have in mind, keep in mind a room may be in many spaces so this behaviour might feel faulty if the space chosen is not the one you expected.

Would it be feasible to put them in a new section

Not in a sane amount of time (would require a lot of modifications to the room list store which I'd like to avoid until we are certain this is a solution we are going to keep)

Would it be feasible to amend the filter hint to say 'filter all spaces'

Sure

Would it be feasible to amend the results to say '13 results in all spaces' instead of '13 results'

Sure

@niquewoodhouse
Copy link
Contributor

@t3chguy thanks for explaining the above. Given this, and the timeline, I just want to focus on the ones that are confirmed as feasible, it's a beta, and it just needs to work alright enough.

Would it be feasible to amend the results to say '13 results in all spaces' instead of '13 results'

If we do this, can we have it as:

  • If you're in no spaces: 13 results
  • If you're in 1 or more spaces: 13 results in all spaces

Would it be feasible to amend the filter hint to say 'filter all spaces'

If we do this, can we have it as:

  • If you're in no spaces: Filter
  • If you're in 1 or more spaces: Filter all spaces

I'm more sold on the first idea above than the second, but think both might work ok enough together.

@t3chguy
Copy link
Member Author

t3chguy commented Apr 29, 2021

will do both together and let you know when you can try out the Netlify build

@t3chguy
Copy link
Member Author

t3chguy commented Apr 29, 2021

image
image

@t3chguy t3chguy requested a review from jryans April 29, 2021 20:55
@t3chguy t3chguy merged commit 0008ef7 into develop Apr 30, 2021
@t3chguy t3chguy deleted the t3chguy/fix/16998 branch April 30, 2021 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The fact filtering doesn't search all spaces is super confusing
3 participants