Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Ensure UI is updated when cross-signing gets disabled #4369

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Ensure UI is updated when cross-signing gets disabled #4369

merged 2 commits into from
Apr 9, 2020

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented Apr 9, 2020 •
edited
Loading

@bwindels bwindels requested a review from a team April 9, 2020 12:17
@bwindels bwindels mentioned this pull request Apr 9, 2020
Merged
jryans
jryans approved these changes Apr 9, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like userTrust... also reached these same places, and you're now emitting that as well, but seems fine to listen for both.

@bwindels
Copy link
Contributor Author

bwindels commented Apr 9, 2020

Looks like userTrust... also reached these same places, and you're now emitting that as well, but seems fine to listen for both.

Indeed, I just wanted to respect the semantics and scope of each event. E.g. if cross-signing is disabled, that will affect trust for the room as a whole. If the user trust changes, we shouldn't expect it to affect trust outside of that user? Not sure, there's so many events flying around. But indeed doesn't hurt, so will just merge.

@bwindels bwindels merged commit c1dcb69 into develop Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwindels @jryans