Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When resetting cross-signing keys, other riot-web sessions don't seem to pick up on it #13056

Closed
bwindels opened this issue Apr 7, 2020 · 2 comments · Fixed by matrix-org/matrix-js-sdk#1312
Closed

When resetting cross-signing keys, other riot-web sessions don't seem to pick up on it #13056

bwindels opened this issue Apr 7, 2020 · 2 comments · Fixed by matrix-org/matrix-js-sdk#1312
Assignees
@bwindels
Labels
A-E2EE-Cross-Signing

Comments

@bwindels
Copy link
Contributor

bwindels commented Apr 7, 2020 •
edited
Loading

Steps to reproduce:

  • have two sessions open for the same user (A & B), ensure typing mxMatrixClientPeg.get().getCrossSigningId() in the console yields the same value.
  • reset cross-sign keys on one of them (device A)
  • typing mxMatrixClientPeg.get().getCrossSigningId() will now yield a different value in each session.
  • refreshing both sessions, each will show an "Unverified session. Was this you?" toast.
  • trying to verify device B from device A will result in device B signature upload failing like:

image
@bwindels
Copy link
Contributor Author

bwindels commented Apr 7, 2020

Related to #12790

@bwindels
Copy link
Contributor Author

bwindels commented Apr 7, 2020

Relevant code seems to be (not) here: https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/crypto/index.js#L1145-L1150

@bwindels bwindels mentioned this issue Apr 7, 2020
Closed
@bwindels bwindels self-assigned this Apr 8, 2020
@bwindels bwindels mentioned this issue Apr 9, 2020
Merged
@bwindels bwindels mentioned this issue Apr 9, 2020
Merged
@bwindels bwindels mentioned this issue Apr 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwindels bwindels

Labels
A-E2EE-Cross-Signing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clear cross-signing keys when detecting the keys have changed matrix-org/matrix-js-sdk
2 participants
@bwindels @jryans