Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

rework SlashCommands to better expose aliases #4302

Merged
merged 5 commits into from
Mar 31, 2020
Merged

rework SlashCommands to better expose aliases #4302

merged 5 commits into from
Mar 31, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 30, 2020

Fixes element-hq/element-web#12919

Once an alias is exact-matched it will show it, but will show the completions matching aliases with their canonical command anyhow.

image
image

@t3chguy t3chguy requested a review from a team March 30, 2020 13:06
t3chguy added 2 commits March 30, 2020 14:09
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally seems sane. For future PRs, please make the TS and functional changes in separate commits for easier review.

src/SlashCommands.tsx Outdated Show resolved Hide resolved
src/SlashCommands.tsx Outdated Show resolved Hide resolved
src/SlashCommands.tsx Outdated Show resolved Hide resolved
t3chguy added 2 commits March 31, 2020 11:49
…matrix-react-sdk into t3chguy/cmds

� Conflicts:
�	src/SlashCommands.tsx
@t3chguy t3chguy requested a review from turt2live March 31, 2020 11:30
@t3chguy t3chguy merged commit 56dda38 into develop Mar 31, 2020
@t3chguy t3chguy deleted the t3chguy/cmds branch April 27, 2020 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if /goto is a thing, put it in the slash command autocompleter
2 participants