Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if /goto is a thing, put it in the slash command autocompleter #12919

Closed
ara4n opened this issue Mar 29, 2020 · 4 comments · Fixed by matrix-org/matrix-react-sdk#4302
Closed

if /goto is a thing, put it in the slash command autocompleter #12919

ara4n opened this issue Mar 29, 2020 · 4 comments · Fixed by matrix-org/matrix-react-sdk#4302
Assignees
@t3chguy

Comments

@ara4n
Copy link
Member

ara4n commented Mar 29, 2020

No description provided.

@tulir
Copy link
Contributor

tulir commented Mar 29, 2020

/goto is just an alias for /join and aliases aren't autocompleted. There's another issue for making /goto work differently: #10128

@jryans
Copy link
Collaborator

jryans commented Mar 30, 2020

Couldn't we add aliases to the autocomplete and help though...?

@tulir
Copy link
Contributor

tulir commented Mar 30, 2020

The autocomplete thing might get a lot of unnecessary entries if aliases were separate, but maybe they can autocomplete the same entry instead of being separate? (i.e. typing /goto will suggest /join)

@t3chguy
Copy link
Member

t3chguy commented Mar 30, 2020

Hopefully not like
image

@t3chguy t3chguy self-assigned this Mar 30, 2020
@t3chguy t3chguy mentioned this issue Mar 30, 2020
Merged
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@richvdh
Remove unused CryptoCallbacks implementations (#12919)
5a9d7ba 
* Remove unused `onSecretRequested` callback

This thing is unused with the rust crypto stack (which is lucky, because it
uses methods that only work with the legacy stack).

* Remove unused `getDehydrationKey` method

This callback is no longer used, so there is no need for an implementation.

* Remove unused `dehydrationCache`

This is no longer written to, so is redundant.

* Remove another write to `CryptoCallbacks.getDehydrationKey`

As before: this hook is no longer used by the js-sdk, so writing to it is
pointless.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rework SlashCommands to better expose aliases matrix-org/matrix-react-sdk
4 participants
@jryans @ara4n @t3chguy @tulir