Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Support $riot: Templates for SSO/CAS urls in the welcome.html page #4279

Merged
merged 9 commits into from
Mar 31, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 25, 2020

Fixes element-hq/element-web#12883

Additionally, there are 4 ways to reach this view:

+ You click Login
+ You navigate to #/login
+ You were already in login for another server but entered an SSO HS URL manually
+ You were already in login for another server but entered your SSO-powered MXID and well-known found your SSO HS URL

in my current implementation I only auto-redirect for the first two cases, is this desirable?

@ara4n

This comment has been minimized.

@t3chguy

This comment has been minimized.

@ara4n

This comment has been minimized.

@t3chguy

This comment has been minimized.

@t3chguy

This comment has been minimized.

@t3chguy

This comment has been minimized.

Signed-off-by: Michael Telatynski <[email protected]>
t3chguy added 6 commits March 27, 2020 09:59
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy changed the title Automatically redirect to SSO when the user clicks through to Login Support $riot: Templates for SSO/CAS urls in the welcome.html page Mar 27, 2020
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy marked this pull request as ready for review March 27, 2020 20:38
@t3chguy t3chguy requested a review from a team March 27, 2020 20:39
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing all the context as to how we went from auto-login to template variables, but this seems fine independently.

We might not need the namespacing, though it doesn't hurt.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we avoid the SSO login flow making you click a 'log in with SSO' button?
3 participants