Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent the user from creating multiple devices whereas a session is available #11643

Closed
giomfo opened this issue Dec 11, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#5423
Closed

Prevent the user from creating multiple devices whereas a session is available #11643

giomfo opened this issue Dec 11, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#5423
Assignees
@t3chguy
Labels
T-Enhancement

Comments

@giomfo
Copy link
Member

giomfo commented Dec 11, 2019

Some Riot-web users add to their Favourites or Bookmarks the welcome or the login url screen.

When these users want to go back to Riot, they land on the login screen and fill their credentials. This creates a new device in their account (most of them are not aware of that). They don't understand why the app fails to decrypt the room history in the encrypted rooms.

Would it be possible to check the local storage when the login screen is loaded by the browser in order to prevent them from logging in again?
@nadonomy
Copy link
Contributor

Great idea! Few questions:

  • If we detect a session in local storage, what account info does the browser know? If we know the matrix id, it'd be great to then display the avatar/username/id with a [Continue as Nad] experience
  • Would the user need to enter their password/re-authenticate?

@uhoreg
Copy link
Member

uhoreg commented Jan 15, 2020

If the app detects that the user is already logged in, it should be able to redirect to the main screen with no interaction, and allow the user to just start using Riot.

@dbkr
Copy link
Member

dbkr commented May 4, 2020

We're tracking this in #12476

@t3chguy

This comment has been minimized.

Sign in to view
t3chguy added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 2, 2020
@t3chguy
Fix login loop where the sso flow returns to #/login
113a9d7 
due to fragmentAfterLogin going back to `#/login`
and element-hq/element-web#11643

Signed-off-by: Michael Telatynski <[email protected]>
t3chguy added a commit that referenced this issue Jun 2, 2020
@t3chguy
Fix login loop where the sso flow returns to #/login
d18b0f8 
due to fragmentAfterLogin going back to `#/login`
and #11643

Signed-off-by: Michael Telatynski <[email protected]>
This was referenced Jun 2, 2020
Merged
Merged
t3chguy added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 3, 2020
@t3chguy
Fix login loop where the sso flow returns to #/login
84d81ff 
due to fragmentAfterLogin going back to `#/login`
and element-hq/element-web#11643

Signed-off-by: Michael Telatynski <[email protected]>
t3chguy added a commit that referenced this issue Jun 3, 2020
@t3chguy
Fix login loop where the sso flow returns to #/login
ddf3d92 
due to fragmentAfterLogin going back to `#/login`
and #11643

Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy self-assigned this Nov 16, 2020
@t3chguy t3chguy mentioned this issue Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redirect user home from auth screens if they are already logged in matrix-org/matrix-react-sdk
5 participants
@dbkr @uhoreg @t3chguy @nadonomy @giomfo