This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Moved read receipts to the bottom of the message #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs sign off from design :) Attaching screenshots to the PR would be great +1000 |
|
|
nadonomy
approved these changes
Mar 5, 2020
There was a problem hiding this comment.
Apologies this slipped through the crack in the review queue, we've made some improvements to our workflow internally so this shouldn't happenn again.
But, assuming we've avoided bitrot, this looks good to me! This has been bugging me for a while so super happy to get this merged.
bwindels
approved these changes
Mar 5, 2020
|
Tests are failing because your branch is behind on develop. Could you rebase please @krkc ? |
turt2live
changed the title
turt2live
added a commit
that referenced
this pull request
Mar 10, 2020
This reverts commit 191abb5.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#4377
I've moved the message read receipts to the bottom of the EventTile.
Signed-off-by: Christopher Kurek [email protected]