Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read receipts gets rendered outside of timeline viewport when typing notification disappears (when they are at the bottom of the event) #12675

Open
bwindels opened this issue Mar 10, 2020 · 10 comments
Open

Read receipts gets rendered outside of timeline viewport when typing notification disappears (when they are at the bottom of the event) #12675

bwindels opened this issue Mar 10, 2020 · 10 comments
Labels
A-Read-Receipts O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect X-Regression Z-Platform-Specific

Comments

@bwindels
Copy link
Contributor

bwindels commented Mar 10, 2020 •
edited
Loading

image

I imagine this regressed in matrix-org/matrix-react-sdk#3892
@bwindels bwindels changed the title read receipts get covered by room status bar when last message in room is a picture Read receipts get covered by room status bar when last message in room is a picture Mar 10, 2020
@bwindels
Copy link
Contributor Author

It happens for text messages too actually.

@bwindels bwindels changed the title Read receipts get covered by room status bar when last message in room is a picture Read receipts get covered by room status bar Mar 10, 2020
@turt2live
Copy link
Member

Likely to be highly related to #12660

@turt2live turt2live self-assigned this Mar 10, 2020
@turt2live
Copy link
Member

@bwindels I can't reproduce this. Do you have more specific instructions?

@bwindels
Copy link
Contributor Author

@bwindels I can't reproduce this. Do you have more specific instructions?

Yeah, looks like #12660, when hovering the read receipt in the screenshot below, it highlights the event above of it.

image

I was able to reproduce the read receipt being covered when in a test room with two users and they are both typing.

@bwindels
Copy link
Contributor Author

Here's a GIF of reproducing it. It happens when the other user's "is typing" notification disappears and their message arrives. Then, after reproing, I'm (slowly and confusingly) trying to show that the RR avatar is still rendered but outside of the timeline viewport.

rrdisappearingafterstoptyping2

@bwindels bwindels changed the title Read receipts get covered by room status bar Read receipts gets rendered outside of timeline viewport when typing notification disappears Mar 10, 2020
@turt2live
Copy link
Member

image

:(

Browser and OS?

@bwindels
Copy link
Contributor Author

Firefox 73.0.1 (64-bit) on Fedora

@uhoreg
Copy link
Member

uhoreg commented Mar 10, 2020

I see the issue too. Firefox 73.0.1 on Debian.

@turt2live
Copy link
Member

Other reports are from MacOS, chrome. Seems like a not-windows issue or I'm failing to follow instructions.

I could not reproduce this on Fedora/Firefox or Ubuntu/Firefox.

We'll try reverting matrix-org/matrix-react-sdk#3892 and see how it goes for now.

@turt2live
Copy link
Member

Revert has been pushed, putting this into the infinite maintenance backlog.

@turt2live turt2live removed their assignment Mar 10, 2020
@turt2live turt2live changed the title Read receipts gets rendered outside of timeline viewport when typing notification disappears Read receipts gets rendered outside of timeline viewport when typing notification disappears (when they are at the bottom of the event) Mar 10, 2020
@t3chguy t3chguy mentioned this issue Feb 28, 2021
Closed
@MadLittleMods MadLittleMods added A-Read-Receipts S-Tolerable Low/no impact on users O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P1 labels Oct 14, 2022
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@florianduros
Update @vector-im/compound-web (#12675)
f59bd6d 
* update deps: `@vector-im/compound-web`

* test: update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Read-Receipts O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect X-Regression Z-Platform-Specific
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bwindels @MadLittleMods @uhoreg @turt2live