This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Delegate all room alias validation to the RoomAliasField validator #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
|
It probably shouldn't say this alias is available to use when you haven't typed anything in yet |
|
I don't disagree but this PR does not change the validator:
|
|
@aaronraimist seems like this was done on purpose: matrix-react-sdk/src/components/views/elements/RoomAliasField.js Lines 96 to 98 in ebf7eb6 |
turt2live
suggested changes
Jan 6, 2020
turt2live
approved these changes
Jan 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#11732
Fixes element-hq/element-web#11737
Signed-off-by: Michael Telatynski [email protected]