Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

room settings add alias button should be greyed out if alias taken #11732

Closed
t3chguy opened this issue Dec 27, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3807
Closed

room settings add alias button should be greyed out if alias taken #11732

t3chguy opened this issue Dec 27, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3807
Assignees
@t3chguy

Comments

@t3chguy
Copy link
Member

t3chguy commented Dec 27, 2019

No description provided.

@aaronraimist
Copy link
Collaborator

Related issue about the error message: #9367

@t3chguy
Copy link
Member Author

t3chguy commented Jan 5, 2020

I have taken the approach to match Room Creation dialog where it is not greyed out but will instantly tell you what went wrong with a validator

@t3chguy t3chguy self-assigned this Jan 5, 2020
@t3chguy t3chguy mentioned this issue Jan 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delegate all room alias validation to the RoomAliasField validator matrix-org/matrix-react-sdk
2 participants
@t3chguy @aaronraimist