Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add bound 3PID warning when changing IS as well #3394

Merged
merged 8 commits into from
Sep 9, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Sep 5, 2019

This extends the bound 3PID warning from the disconnect button to also appear
when changing the IS as well. At the moment, the text is a bit terse, but will
be improved separately.

2019-09-05 at 17 46

Fixes element-hq/element-web#10749

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This extends the bound 3PID warning from the disconnect button to also appear
when changing the IS as well. At the moment, the text is a bit terse, but will
be improved separately.

Fixes element-hq/element-web#10749
@jryans jryans requested a review from a team September 5, 2019 16:53
src/components/views/settings/SetIdServer.js Outdated Show resolved Hide resolved
src/components/views/settings/SetIdServer.js Outdated Show resolved Hide resolved
src/components/views/settings/SetIdServer.js Outdated Show resolved Hide resolved
Earlier changes in this branch removed the "next step" of saving from the
dialogs, so we need to fold in the CORS error case.
@jryans jryans requested a review from turt2live September 6, 2019 10:55
This tweaks the bound 3PID text and adds danger styling.

Fixes element-hq/element-web#10750
@jryans jryans merged commit a03b224 into develop Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing from one IS to another does not trigger bound 3PID warning
2 participants