Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing from one IS to another does not trigger bound 3PID warning #10749

Closed
jryans opened this issue Sep 4, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3394
Closed

Changing from one IS to another does not trigger bound 3PID warning #10749

jryans opened this issue Sep 4, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3394
Assignees
@jryans
Labels
A-Identity-Server Privacy T-Defect

Comments

@jryans
Copy link
Collaborator

jryans commented Sep 4, 2019

The warning only seems to appear when disconnecting, but should also appear for changing.
@jryans jryans self-assigned this Sep 5, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 5, 2019
@jryans
Add bound 3PID warning when changing IS as well
7315730 
This extends the bound 3PID warning from the disconnect button to also appear
when changing the IS as well. At the moment, the text is a bit terse, but will
be improved separately.

Fixes element-hq/element-web#10749
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 5, 2019
@jryans
Add bound 3PID warning when changing IS as well
d5552e4 
This extends the bound 3PID warning from the disconnect button to also appear
when changing the IS as well. At the moment, the text is a bit terse, but will
be improved separately.

Fixes element-hq/element-web#10749
@jryans jryans mentioned this issue Sep 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Identity-Server Privacy T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bound 3PID warning when changing IS as well matrix-org/matrix-react-sdk
1 participant
@jryans