Touch up settings: alignment, spacing, error states #3330
Conversation
Fixes element-hq/element-web#10554 Issues fixed: * Fields were not ~30px from the avatar (too much right margin) * Tooltips overflowed the dialog on some resolutions * SetIdServer didn't have an error state for making the field red * Spacing between sections in Discovery was wrong (fixed by just removing the problematic n+2 selector - it didn't help anything)
| @@ -26,10 +26,6 @@ limitations under the License. | |||
| height: 4em; | |||
| } | |||
|
|
|||
| .mx_ProfileSettings_controls .mx_Field { | |||
There was a problem hiding this comment.
Removed because it was added space on top of the spacing already in place. Did not serve a useful purpose here.
Yes, indeed. The original design called for it to be a text box but unfortunately that makes the assumption that one can change it. The approach currently in place is the temporary solution (insert air quotes around temporary). |
Maybe a read-only / disabled field could work? |
|
Concern with that was that people would be confused as to why it is disabled :( |
Fixes element-hq/element-web#10554
Issues fixed:
Screenshots:
Error state of identity server & shortened tooltip:
Fixed field alignment:
New discovery section spacing:
The whole page:
