Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings page fields are all out of alignment / settings page is wonky #10554

Closed
turt2live opened this issue Aug 14, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3330
Closed

Settings page fields are all out of alignment / settings page is wonky #10554

turt2live opened this issue Aug 14, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3330
Assignees
@turt2live
Labels
A-User-Settings P1 T-Defect

Comments

@turt2live
Copy link
Member

see matrix-org/matrix-react-sdk#3300 (comment)
@turt2live turt2live self-assigned this Aug 14, 2019
@turt2live turt2live mentioned this issue Aug 14, 2019
Merged
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 19, 2019
@jryans
Tweak Settings padding / margin slightly
8a7b43f 
This makes a few small tweaks to Settings padding and margin, but more is still
needed. I am told that element-hq/element-web#10554 will
soon take a holistic view on the problem, so this is a more conservation
temporary change.
@jryans jryans mentioned this issue Aug 19, 2019
Merged
@turt2live turt2live changed the title Settings page fields are all out of alignment Settings page fields are all out of alignment / settings page is wonky Aug 20, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 20, 2019
@turt2live
Touch up settings: alignment, spacing, error states
f55a400 
Fixes element-hq/element-web#10554

Issues fixed:
* Fields were not ~30px from the avatar (too much right margin)
* Tooltips overflowed the dialog on some resolutions
* SetIdServer didn't have an error state for making the field red
* Spacing between sections in Discovery was wrong (fixed by just removing the problematic n+2 selector - it didn't help anything)
@turt2live turt2live mentioned this issue Aug 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-User-Settings P1 T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Touch up settings: alignment, spacing, error states matrix-org/matrix-react-sdk
1 participant
@turt2live