Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

If on trackpad, don't mess with horizontal scrolling. #3148

Merged
merged 5 commits into from
Jun 28, 2019
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions src/components/structures/IndicatorScrollbar.js
Original file line number Diff line number Diff line change
Expand Up @@ -131,17 +131,28 @@ export default class IndicatorScrollbar extends React.Component {
// the harshness of the scroll behaviour. Should be a value between 0 and 1.
const yRetention = 1.0;

// Check for trackpad users every so often to avoid boosting their scroll.
// See https://github.com/vector-im/riot-web/issues/10005
// whenever we see horizontal scrolling, assume the user is on a trackpad
// for at least the next 1 minute.
const now = new Date().getTime();
if (now >= this._checkAgainForTrackpad) {
this._likelyTrackpadUser = Math.abs(e.deltaX) > 0;
this._checkAgainForTrackpad = now + (15 * 60 * 1000); // 15min
if (Math.abs(e.deltaX) > 0) {
this._likelyTrackpadUser = true;
this._checkAgainForTrackpad = now + (1 * 60 * 1000);
} else {
// if we haven't seen any horizontal scrolling for a while, assume
// the user might have plugged in a mousewheel
if (this._likelyTrackpadUser && now >= this._checkAgainForTrackpad) {
this._likelyTrackpadUser = false;
}
}

// don't mess with the horizontal scroll for trackpad users
// See https://github.com/vector-im/riot-web/issues/10005
if (this._likelyTrackpadUser) {
return;
}

const safeToBoost = !this._likelyTrackpadUser;
if (Math.abs(e.deltaX) <= xyThreshold) { // we are vertically scrolling.

jryans marked this conversation as resolved.
Show resolved Hide resolved
if (Math.abs(e.deltaX) <= xyThreshold) {
// HACK: We increase the amount of scroll to counteract smooth scrolling browsers.
// Smooth scrolling browsers (Firefox) use the relative area to determine the scroll
// amount, which means the likely small area of content results in a small amount of
Expand All @@ -152,7 +163,7 @@ export default class IndicatorScrollbar extends React.Component {
const additionalScroll = e.deltaY < 0 ? -50 : 50;

// noinspection JSSuspiciousNameCombination
const val = Math.abs(e.deltaY) < 25 && safeToBoost ? (e.deltaY + additionalScroll) : e.deltaY;
const val = Math.abs(e.deltaY) < 25 ? (e.deltaY + additionalScroll) : e.deltaY;
this._scrollElement.scrollLeft += val * yRetention;
}
}
Expand Down