This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
If on trackpad, don't mess with horizontal scrolling. #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trackpad heuristic is 'if 15 minutes of no horizontal scrollwheel events, assume user may have switched to mousewheel'
turt2live
suggested changes
Jun 26, 2019
| @@ -152,7 +164,7 @@ export default class IndicatorScrollbar extends React.Component { | |||
| const additionalScroll = e.deltaY < 0 ? -50 : 50; | |||
|
|
|||
| // noinspection JSSuspiciousNameCombination | |||
| const val = Math.abs(e.deltaY) < 25 && safeToBoost ? (e.deltaY + additionalScroll) : e.deltaY; | |||
| const val = Math.abs(e.deltaY) < 25 ? (e.deltaY + additionalScroll) : 0; | |||
There was a problem hiding this comment.
this breaks vertical scrolling for non-smoothscrolling browsers (ie: windows)
There was a problem hiding this comment.
yup, this was a thinko; suggestions welcome
There was a problem hiding this comment.
instead of zero, e.deltaY, like it was before
| this._checkAgainForTrackpad = now + (15 * 60 * 1000); // 15min | ||
| } | ||
| else { | ||
| // if we haven't seen any horizontal scrolling for >15 minutes, assume |
There was a problem hiding this comment.
we should bump this down to a minute if we're not sampling.
turt2live
approved these changes
Jun 26, 2019
turt2live
reviewed
Jun 26, 2019
|
I am assuming @ara4n wants this to land but is busy with other things, so merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trackpad heuristic is 'if 15 minutes of no horizontal scrollwheel events, assume user may have switched to mousewheel'