Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

change profile keybind to backtick from i due to italics conflict #3077

Merged
merged 1 commit into from
Jun 6, 2019
Merged

change profile keybind to backtick from i due to italics conflict #3077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Keyboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ export const KeyCode = {
KEY_X: 88,
KEY_Y: 89,
KEY_Z: 90,
KEY_BACKTICK: 223,
};

export function isOnlyCtrlOrCmdKeyEvent(ev) {
Expand Down
5 changes: 3 additions & 2 deletions src/components/structures/LoggedInView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,10 +325,11 @@ const LoggedInView = React.createClass({
handled = true;
}
break;
case KeyCode.KEY_I:
case KeyCode.KEY_BACKTICK:
// Ideally this would be CTRL+P for "Profile", but that's
// taken by the print dialog. CTRL+I for "Information"
// will have to do.
// was previously chosen but conflicted with italics in
// composer, so CTRL+` it is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a sinking feeling this is going to become a novel titled "Key Bindings in Riot: A Short Story by Everyone Ever"


if (ctrlCmdOnly) {
dis.dispatch({
Expand Down