Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

change profile keybind to backtick from i due to italics conflict #3077

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 6, 2019

Fixes element-hq/element-web#9958

Signed-off-by: Michael Telatynski [email protected]

@t3chguy t3chguy requested a review from a team June 6, 2019 23:09
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming the build passes - thank you!

// Ideally this would be CTRL+P for "Profile", but that's
// taken by the print dialog. CTRL+I for "Information"
// will have to do.
// was previously chosen but conflicted with italics in
// composer, so CTRL+` it is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a sinking feeling this is going to become a novel titled "Key Bindings in Riot: A Short Story by Everyone Ever"

@t3chguy t3chguy merged commit 3f6b266 into develop Jun 6, 2019
@t3chguy t3chguy deleted the t3chguy/change_keybind branch May 25, 2020 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMD+I triggers top left context menu
2 participants