This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix initial letter avatar vertical offset in Firefox #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In at least Firefox, the case of relative positioned inline elements (such as mx_BaseAvatar) with absolute positioned children (such as mx_BaseAvatar_initial) is a dark corner full of spider webs. It will give different results during full reflow of the page vs. incremental reflow of small portions. While that's surely a browser bug, we can avoid it by using `inline-block` instead of the default `inline`. Fixes element-hq/element-web#5594 Might help with element-hq/element-web#9088 See also https://bugzilla.mozilla.org/show_bug.cgi?id=1535053 and https://bugzilla.mozilla.org/show_bug.cgi?id=255139 for more details on browser behavior in this case.
turt2live
approved these changes
Mar 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In at least Firefox, the case of relative positioned inline elements (such as
mx_BaseAvatar) with absolute positioned children (such as mx_BaseAvatar_initial)
is a dark corner full of spider webs. It will give different results during full
reflow of the page vs. incremental reflow of small portions. While that's surely
a browser bug, we can avoid it by using
inline-blockinstead of the defaultinline.Fixes element-hq/element-web#5594
Might help with element-hq/element-web#9088
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1535053 and
https://bugzilla.mozilla.org/show_bug.cgi?id=255139 for more details on browser
behavior in this case.
I used https://avatars-styling.glitch.me/ as a reduced test case for this bug.
Before:
After: