Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MELS avatars have wrong vertical offset in Firefox #5594

Closed
ara4n opened this issue Nov 14, 2017 · 8 comments
Closed

MELS avatars have wrong vertical offset in Firefox #5594

ara4n opened this issue Nov 14, 2017 · 8 comments
Assignees
@jryans
Labels
P2 S-Tolerable Low/no impact on users T-Defect Z-Upstream

Comments

@ara4n
Copy link
Member

ara4n commented Nov 14, 2017

Bizarrely and depressingly, toggling the line-height style attribute on & off on the initial fixes it :(

screen shot 2017-11-14 at 16 16 41
@uhoreg
Copy link
Member

uhoreg commented Nov 14, 2017

dup of #4096 (it happened in pre-57 too)

@uhoreg uhoreg closed this as completed Nov 14, 2017
@uhoreg
Copy link
Member

uhoreg commented Nov 14, 2017

Oh, wait, this is a different issue. Sorry for the noise.

@uhoreg uhoreg reopened this Nov 14, 2017
@lampholder lampholder added S-Tolerable Low/no impact on users Help Wanted Extra attention is needed S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 ui/ux labels Nov 22, 2017
@lampholder
Copy link
Member

Fixed! (As of ff 64 something, if we didn't fix this in Riot itself)

@lampholder
Copy link
Member

Ah no it's not.

MELS that were in the timeline already seemed fine; MELS that was constructed whilst I was in the room seemed broken.

👍:
screenshot 2018-09-12 at 10 34 13

👎:
screenshot 2018-09-12 at 11 22 22

@lampholder lampholder reopened this Sep 12, 2018
@lampholder lampholder changed the title Initialled MELS avatars have wrong vertical offset in Firefox 57 MELS avatars have wrong vertical offset in Firefox 57 Sep 12, 2018
@lampholder
Copy link
Member

But I'm bumping from P1 'cause I don't think it actually looks noticably broken.

@lampholder lampholder added P2 and removed P1 labels Sep 12, 2018
@jryans
Copy link
Collaborator

jryans commented Oct 30, 2018

I believe this is a styling bug in Firefox. I am working on a reduced test case.

@ara4n
Copy link
Member Author

ara4n commented Feb 10, 2019

This is still broken in the redesign:

screenshot 2019-02-10 at 22 43 28

@ara4n ara4n changed the title MELS avatars have wrong vertical offset in Firefox 57 MELS avatars have wrong vertical offset in Firefox Feb 10, 2019
@jryans jryans mentioned this issue Mar 13, 2019
Closed
@jryans
Copy link
Collaborator

jryans commented Mar 13, 2019

I believe this is partly a Firefox style caching / race condition bug, which I have reported upstream. It is interesting, however, that we now also have reports of similar issues in Chrome as well (#9088).

I will continue investigating style tweaks in Riot to avoid these strange browser behaviours.

@jryans jryans self-assigned this Mar 13, 2019
@jryans jryans added T-Defect and removed Help Wanted Extra attention is needed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Mar 14, 2019
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Mar 14, 2019
@jryans
Fix initial letter avatar vertical offset in Firefox
990d6de 
In at least Firefox, the case of relative positioned inline elements (such as
mx_BaseAvatar) with absolute positioned children (such as mx_BaseAvatar_initial)
is a dark corner full of spider webs. It will give different results during full
reflow of the page vs. incremental reflow of small portions. While that's surely
a browser bug, we can avoid it by using `inline-block` instead of the default
`inline`.

Fixes element-hq/element-web#5594
Might help with element-hq/element-web#9088

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1535053 and
https://bugzilla.mozilla.org/show_bug.cgi?id=255139 for more details on browser
behavior in this case.
@jryans jryans mentioned this issue Mar 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
P2 S-Tolerable Low/no impact on users T-Defect Z-Upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jryans @uhoreg @ara4n @lampholder