This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Bring back user view #2666
Merged
Bring back user view #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a UserView that contains a MainSplit with an empty div and a RightPanel, preset to the given member. UserView fetches the profile and creates a fake member, which it passed on to the RightPanel. this doesn't use the view_user action on purpose, to avoid any interference of the UserView when trying to view a room member.
|
(@bwindels says it's ready for review.) |
jryans
suggested changes
Feb 20, 2019
res/css/structures/_MainSplit.scss
Outdated
| @@ -0,0 +1,21 @@ | |||
| /* | |||
| Copyright 2015, 2016 OpenMarket Ltd | |||
| action: 'view_user', | ||
| member: member, | ||
| }); | ||
| // get profile info here somehow |
There was a problem hiding this comment.
What does this comment mean...?
| }); | ||
| // get profile info here somehow | ||
|
|
||
| this.notifyNewScreen('user/' + userId); |
There was a problem hiding this comment.
Nit: Indentation doesn't seem right here...?
| let backButton; | ||
| if (this.props.member.roomId) { | ||
| backButton = (<AccessibleButton className="mx_MemberInfo_cancel" | ||
| onClick={this.onCancel} |
There was a problem hiding this comment.
Nit: Indentation seems strange here
| */ | ||
|
|
||
| .mx_MainSplit { | ||
| display: flex; |
There was a problem hiding this comment.
I guess other users for MainSplit were also setting display: flex in more specific rule sets, so we could remove display: flex from those.
jryans
approved these changes
Feb 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a UserView that contains a MainSplit with an empty div
and a RightPanel, preset to the given member.
UserView fetches the profile and creates a fake member, which
it passed on to the RightPanel.
this doesn't use the view_user action on purpose, to avoid any
interference of the UserView when trying to view a room member.
Fixes element-hq/element-web#8791