Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct links to users lead to confused / broken state #8791

Closed
anoadragon453 opened this issue Feb 19, 2019 · 6 comments
Closed

Direct links to users lead to confused / broken state #8791

anoadragon453 opened this issue Feb 19, 2019 · 6 comments

Comments

@anoadragon453
Copy link
Member

anoadragon453 commented Feb 19, 2019

image

Description

Lots of people use matrix.to links on their contact page as their way of saying "Contact me on Matrix!". After the redesign, these links, such as https://riot.im/app/#/user/@andrewm:amorgan.xyz lead to a blank and empty page.

This happens whether you're logged in or not.

Steps to reproduce

@ara4n
Copy link
Member

ara4n commented Feb 19, 2019

it's worse than this - i think /user links are broken even if you are logged in. I could have sworn i'd filed a bug for this but can't find it now. E.g. https://riot.im/develop/#/user/@matthew:matrix.org (once logged in) doesn't show the MemberInfo.

@anoadragon453
Copy link
Member Author

anoadragon453 commented Feb 19, 2019

Yikes, indeed. Edited.

@jryans
Copy link
Collaborator

jryans commented Feb 19, 2019

Yes, seems likes a duplicate of #8642, but this now has more info and labels. I'll close that one in favor of this.

@jryans jryans changed the title matrix.to links to users lead to confused state Direct links to users lead to confused / broken state Feb 19, 2019
@jryans
Copy link
Collaborator

jryans commented Feb 19, 2019

Originally posted by @bwindels in #8642 (comment):

I sort of assumed this wasn't used anymore during the room header refactoring, my bad.

How should this look though, like before, shoved in the right panel with the middle panel empty?

@jryans
Copy link
Collaborator

jryans commented Feb 21, 2019

Fixed by matrix-org/matrix-react-sdk#2666

@jryans jryans closed this as completed Feb 21, 2019
@anoadragon453
Copy link
Member Author

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants