Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Render disabled mxField textareas as disabled #2591

Merged
merged 3 commits into from
Feb 8, 2019
Merged

Render disabled mxField textareas as disabled #2591

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5934c1
Render disabled mxField textareas as disabled
turt2live Feb 7, 2019
cf13666
Merge branch 'develop' into travis/settings/disable-topic
turt2live Feb 8, 2019
debac60
Include input and select labels in disabled stlyes
turt2live Feb 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion res/css/views/elements/_Field.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ limitations under the License.
}

.mx_Field select:disabled,
.mx_Field input:disabled {
.mx_Field input:disabled,
.mx_Field textarea:disabled,
.mx_Field textarea:disabled + label {
Copy link
Collaborator

@jryans jryans Feb 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling label as well seems good... but surely we should do the same for select and input labels as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't seem to need to in order to get the disabled effect.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but for example the theme dropdown's label in Settings doesn't seem disabled...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looked fairly disabled to me :(

I'll double check all the browsers again, and probably flip a table doing it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefox on macOS looks like:

2019-02-08 at 15 22

which seems to have the label color #454545 (normal) and not #888 (greyed, as would be used here if extended).

background-color: $field-focused-label-bg-color;
color: $greyed-fg-color;
}