-
-
Notifications
You must be signed in to change notification settings - Fork 827
Render disabled mxField textareas as disabled #2591
Conversation
.mx_Field input:disabled { | ||
.mx_Field input:disabled, | ||
.mx_Field textarea:disabled, | ||
.mx_Field textarea:disabled + label { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Styling label
as well seems good... but surely we should do the same for select
and input
labels as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't seem to need to in order to get the disabled effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, but for example the theme dropdown's label in Settings doesn't seem disabled...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looked fairly disabled to me :(
I'll double check all the browsers again, and probably flip a table doing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firefox on macOS looks like:
which seems to have the label color #454545 (normal) and not #888 (greyed, as would be used here if extended).
@jryans please take another look. For reference, here's a giant blob of examples:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems correct to me, thanks! 😁
I'm merging this because the test breakages are unrelated and I don't want to wait another hour in the CI queue. |
Fixes element-hq/element-web#8440