Fix screen sharing in recent Chrome #4241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dreadful hack to work around a bug in recent chrome/electron's WebRTC, as explained. I'm not sure which is the least hideous out of this (ie. repeatedly calling setCodecPreferences and seeing if it crashes each time) or hardcoding the bad codec and skipping it. Opinions welcome.
dbkr
added
T-Defect
backport staging
t3chguy
reviewed
Jun 13, 2024
RiotRobot
pushed a commit
that referenced
this pull request
Jun 13, 2024
* Fix screen sharing in recent Chrome Dreadful hack to work around a bug in recent chrome/electron's WebRTC, as explained. I'm not sure which is the least hideous out of this (ie. repeatedly calling setCodecPreferences and seeing if it crashes each time) or hardcoding the bad codec and skipping it. Opinions welcome. * Unused import * Remove commented line (cherry picked from commit 9218f63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dreadful hack to work around a bug in recent chrome/electron's WebRTC, as explained.
I'm not sure which is the least hideous out of this (ie. repeatedly calling setCodecPreferences and seeing if it crashes each time) or hardcoding the bad codec and skipping it. Opinions welcome. Edit: LiveKit work around this bug by using the receiver codecs (livekit/client-sdk-js#1088) so that's also an option.
This will probably want backporting to the release.
Fixes element-hq/element-desktop#1703
Checklist
public/exportedsymbols have accurate TSDoc documentation.